Eliminate CHECK from CryptohomeLibrary::LoadSystemSalt

chrome/browser/chromeos/login/parallel_authenticator.cc

Index: chrome/browser/chromeos/login/parallel_authenticator.cc
diff --git a/chrome/browser/chromeos/login/parallel_authenticator.cc b/chrome/browser/chromeos/login/parallel_authenticator.cc
index 54b5aaf7e8e5cbffd9f6d14ea0bfe758958f2015..85f724d8e604f8c672d46b3f9a00b901e1d85a13 100644
--- a/chrome/browser/chromeos/login/parallel_authenticator.cc
+++ b/chrome/browser/chromeos/login/parallel_authenticator.cc
@@ -187,6 +187,8 @@ std::string HashPassword(const std::string& password) {
   // Get salt, ascii encode, update sha with that, then update with ascii
   // of password, then end.
   std::string ascii_salt = CryptohomeLibrary::Get()->GetSystemSalt();
+  // TODO(stevenjb/nkostylev): Handle empty system salt gracefully.
+  CHECK(!ascii_salt.empty());

[zel, 2013/09/20 16:28:05]

how's this helping to fix this problem?

you've just move the assert from one place to another

[stevenjb, 2013/09/20 16:42:23]

The crash we were seeing occurred because some extensions code was trying to
access system salt early. We still need to ensure that we don't try to login
without system salt. We should absolutely change this to be more robust, but
someone more familiar with the login code should do this. There's a long
standing bug to fix this, crbug.com/141009.

[zel, 2013/09/20 16:48:40]

Yes, I would rather:
a) Find out which extension is responsible for that (there are not that many of
them running at login screen) and figure out if it's really launched too early,
and
b) Revert this CL, and
c) Fix http://crbug.com/141009 properly

   char passhash_buf[kPasswordHashLength];
 
   // Hash salt and password