Eliminate CHECK from CryptohomeLibrary::LoadSystemSalt

chrome/browser/chromeos/login/managed/managed_user_authenticator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/managed/managed_user_authenticator.h"
 
 #include "base/bind.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "chrome/browser/chromeos/boot_times_loader.h"
@@ skipping 85 matching lines @@
                  "CryptohomeAddKey-LMU-End",
                  attempt,
                  resolver));
 }
 
 // Returns hash of |password|, salted with the system salt.
 std::string HashPassword(const std::string& password) {
   // Get salt, ascii encode, update sha with that, then update with ascii
   // of password, then end.
   std::string ascii_salt = CryptohomeLibrary::Get()->GetSystemSalt();
+  // TODO(stevenjb/nkostylev): Handle empty system salt gracefully.
+  CHECK(!ascii_salt.empty());

[zel, 2013/09/20 16:28:05]

same here

   char passhash_buf[kPasswordHashLength];
 
   // Hash salt and password
   crypto::SHA256HashString(
       ascii_salt + password, &passhash_buf, sizeof(passhash_buf));
 
   // Only want the top half for 'weak' hashing so that the passphrase is not
   // immediately exposed even if the output is reversed.
   const int encoded_length = sizeof(passhash_buf) / 2;
 
@@ skipping 231 matching lines @@
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   return hash_obtained_;
 }
 
 std::string ManagedUserAuthenticator::AuthAttempt::hash() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   return hash_;
 }
 
 }  // namespace chromeos