Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 23903033: Revert 157524 "Get rid of fastMallocGoodSize() and replace it wi..." (Closed)

Created:
7 years, 3 months ago by Chris Evans
Modified:
7 years, 3 months ago
Reviewers:
Chris Evans
CC:
blink-reviews
Visibility:
Public.

Description

Revert 157524 "Get rid of fastMallocGoodSize() and replace it wi..." > Get rid of fastMallocGoodSize() and replace it with something generic. > > - fastMallocGoodSize() was Mac-specific and it looks relatively slow and > non-inlineable. The replacement is based around a single lookup into a small > table. > - We now have allocation quantization on all platforms for Vector. I've > verified that many Vector instantiations are able to recover previously-wasted > memory as real element capacity. See bug for details. > - The quantization is also immediately suitable for use with the Partition > allocator, to avoid fragmentation due to excessive numbers of buckets. To be > followed up in a future patch series. > > > BUG=286477 > > Review URL: https://chromiumcodereview.appspot.com/23604048 TBR=cevans@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -151 lines) Patch
M trunk/Source/wtf/FastMalloc.h View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/Source/wtf/FastMalloc.cpp View 2 chunks +16 lines, -0 lines 0 comments Download
D trunk/Source/wtf/QuantizedAllocation.h View 1 chunk +0 lines, -84 lines 0 comments Download
D trunk/Source/wtf/QuantizedAllocation.cpp View 1 chunk +0 lines, -54 lines 0 comments Download
M trunk/Source/wtf/Vector.h View 3 chunks +7 lines, -7 lines 0 comments Download
M trunk/Source/wtf/WTF.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/Source/wtf/WTF.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M trunk/Source/wtf/wtf.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Evans
7 years, 3 months ago (2013-09-10 16:25:30 UTC) #1
Chris Evans
7 years, 3 months ago (2013-09-10 16:25:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r157525.

Powered by Google App Engine
This is Rietveld 408576698