Issue 23903030: Disable PageMeasurementUnitTest.testGotQueryParams as it is failing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23903030: Disable PageMeasurementUnitTest.testGotQueryParams as it is failing. (Closed)

Created:
7 years, 3 months ago by Jói

Modified:
7 years, 3 months ago

Reviewers:
bulach

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org, achuithb, Dominik Grewe

Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr

Visibility:
Public.

Disable PageMeasurementUnitTest.testGotQueryParams as it is failing. TBR=bulach@chromium.org NOTRY=true BUG=288631 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222252

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tools/telemetry/telemetry/page/page_measurement_unittest.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Jói

Marcus, will TBR as this is lighting up the whole tree. Cheers, Jói

7 years, 3 months ago (2013-09-10 11:34:50 UTC) #1

bulach

lgtm, thanks! I don't think the blame list is the one to blame :) but ...

7 years, 3 months ago (2013-09-10 11:37:17 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/23903030/1

7 years, 3 months ago (2013-09-10 11:38:44 UTC) #3

Jói

Yeah, I think both of the changes on the blame list were already reverted as ...

7 years, 3 months ago (2013-09-10 11:38:44 UTC) #4

Message was sent while issue was closed.

Change committed as 222252