Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1366)

Issue 23903029: [HTML Imports] Employ load/error events to stabilize polling-based tests. (Closed)

Created:
7 years, 3 months ago by Hajime Morrita
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

[HTML Imports] Employ load/error events to stabilize polling-based tests. Now HTML Imports suppors load end error events, even inside the imported document. Let's use it to make tests less flaky. BUG=240592 R=dominicc,dglazkov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157583

Patch Set 1 #

Total comments: 1

Patch Set 2 : For landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -31 lines) Patch
M LayoutTests/fast/dom/custom/registration-context-sharing.html View 1 1 chunk +4 lines, -15 lines 0 comments Download
M LayoutTests/http/tests/htmlimports/import-script-block-crossorigin-dynamic.html View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/http/tests/htmlimports/resources/cors-having-crossorigin-scripts.cgi View 1 chunk +20 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hajime Morrita
@dominicc: PTAL and cq?
7 years, 3 months ago (2013-09-10 09:09:43 UTC) #1
dominicc (has gone to gerrit)
On 2013/09/10 09:09:43, morrita1 wrote: > @dominicc: PTAL and cq? LGTM modulo one comment inline.
7 years, 3 months ago (2013-09-10 23:05:57 UTC) #2
dominicc (has gone to gerrit)
Pushed the wrong button... and here's the comment: https://codereview.chromium.org/23903029/diff/1/LayoutTests/fast/dom/custom/registration-context-sharing.html File LayoutTests/fast/dom/custom/registration-context-sharing.html (right): https://codereview.chromium.org/23903029/diff/1/LayoutTests/fast/dom/custom/registration-context-sharing.html#newcode150 LayoutTests/fast/dom/custom/registration-context-sharing.html:150: t.step(function ...
7 years, 3 months ago (2013-09-10 23:06:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/23903029/6001
7 years, 3 months ago (2013-09-11 04:21:16 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-11 06:41:33 UTC) #5
Message was sent while issue was closed.
Change committed as 157583

Powered by Google App Engine
This is Rietveld 408576698