Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 23903011: Modify devices page to match the latest mocks (Closed)

Created:
7 years, 3 months ago by Noam Samuel
Modified:
7 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Modify devices page to match the latest mocks Incorporate printer list from cloudprint and modify cloud print page to match mocks, adding necessary functionality along the way. BUG=286157 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221887

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : Fix browser test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -314 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +22 lines, -1 line 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.css View 1 2 3 2 chunks +39 lines, -15 lines 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.html View 5 chunks +24 lines, -16 lines 0 comments Download
M chrome/browser/resources/local_discovery/local_discovery.js View 1 2 3 10 chunks +158 lines, -106 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h View 1 2 3 6 chunks +37 lines, -35 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 13 chunks +161 lines, -135 lines 0 comments Download
M chrome/test/data/webui/local_discovery_ui_test.js View 1 2 3 4 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Noam Samuel
7 years, 3 months ago (2013-09-04 23:34:03 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/23903011/diff/6001/chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc File chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc (right): https://codereview.chromium.org/23903011/diff/6001/chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc#newcode39 chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc:39: source->AddLocalizedString("addingErrorMessage", missaligned
7 years, 3 months ago (2013-09-06 01:04:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/23903011/6001
7 years, 3 months ago (2013-09-06 01:11:06 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/local_discovery/local_discovery.css: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-06 01:11:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/23903011/17001
7 years, 3 months ago (2013-09-06 17:51:57 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=152198
7 years, 3 months ago (2013-09-06 20:40:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/23903011/17001
7 years, 3 months ago (2013-09-06 21:17:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/23903011/48001
7 years, 3 months ago (2013-09-06 21:57:57 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 04:21:15 UTC) #9
Message was sent while issue was closed.
Change committed as 221887

Powered by Google App Engine
This is Rietveld 408576698