tools/telemetry/telemetry/core/platform/profiler/strace_profiler.py - Issue 23902027: telemetry: Make trace profiler work with trace-based benchmarks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/strace_profiler.py

Issue 23902027: telemetry: Make trace profiler work with trace-based benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add subset test for category filters. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/browser.py ('k') | tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/strace_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/strace_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/strace_profiler.py

index f2701068c37de29acff104756aefcb1df7ad8f6d..c22140bf5f681aa41551473929b56dbe21897cd7 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/strace_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/strace_profiler.py

@@ -241,8 +241,7 @@ class StraceProfiler(profiler.Profiler):

for single_process in self._process_profilers:

out_json.extend(single_process.CollectProfile())

- self._browser_backend.StopTracing()

- model = self._browser_backend.GetTraceResultAndReset().AsTimelineModel()

+ model = self._browser_backend.StopTracing().AsTimelineModel()

out_json.extend(_GenerateTraceMetadata(model))

with open(self._output_file, 'w') as f:

« no previous file with comments | « tools/telemetry/telemetry/core/browser.py ('k') | tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py » ('j') | no next file with comments »