Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py

Issue 23902027: telemetry: Make trace profiler work with trace-based benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add subset test for category filters. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py b/tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py
index afbb3b88a8d0df4f48ccef4f75c1f3ac9b64888c..b2b0fa3591a424f8dd4c75b994343b585f72ef91 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py
@@ -11,6 +11,52 @@ from telemetry.core import util
from telemetry.core.backends.chrome import tracing_backend
from telemetry.unittest import tab_test_case
+class CategoryFilterTest(unittest.TestCase):
+ def testIsSubset(self):
+ b = tracing_backend.CategoryFilter(None)
+ a = tracing_backend.CategoryFilter(None)
+ self.assertEquals(a.IsSubset(b), True)
+
+ b = tracing_backend.CategoryFilter(None)
+ a = tracing_backend.CategoryFilter("test1,test2")
+ self.assertEquals(a.IsSubset(b), True)
+
+ b = tracing_backend.CategoryFilter(None)
+ a = tracing_backend.CategoryFilter("-test1,-test2")
+ self.assertEquals(a.IsSubset(b), True)
+
+ b = tracing_backend.CategoryFilter("test1,test2")
+ a = tracing_backend.CategoryFilter(None)
+ self.assertEquals(a.IsSubset(b), None)
+
+ b = tracing_backend.CategoryFilter(None)
+ a = tracing_backend.CategoryFilter("test*")
+ self.assertEquals(a.IsSubset(b), None)
+
+ b = tracing_backend.CategoryFilter("test?")
+ a = tracing_backend.CategoryFilter(None)
+ self.assertEquals(a.IsSubset(b), None)
+
+ b = tracing_backend.CategoryFilter("test1")
+ a = tracing_backend.CategoryFilter("test1,test2")
+ self.assertEquals(a.IsSubset(b), False)
+
+ b = tracing_backend.CategoryFilter("-test1")
+ a = tracing_backend.CategoryFilter("test1")
+ self.assertEquals(a.IsSubset(b), False)
+
+ b = tracing_backend.CategoryFilter("test1,test2")
+ a = tracing_backend.CategoryFilter("test2,test1")
+ self.assertEquals(a.IsSubset(b), True)
+
+ b = tracing_backend.CategoryFilter("-test1,-test2")
+ a = tracing_backend.CategoryFilter("-test2")
+ self.assertEquals(a.IsSubset(b), False)
+
+ b = tracing_backend.CategoryFilter("disabled-by-default-test1")
+ a = tracing_backend.CategoryFilter(
+ "disabled-by-default-test1,disabled-by-default-test2")
+ self.assertEquals(a.IsSubset(b), False)
class TracingBackendTest(tab_test_case.TabTestCase):
def _StartServer(self):
« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py ('k') | tools/telemetry/telemetry/core/browser.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698