Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

Issue 23902027: telemetry: Make trace profiler work with trace-based benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add subset test for category filters. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
index 5c2c009d63e69496d7da70acccd872a1a8280ed4..460f7d67746a6ece9f603720de31379a78797704 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py
@@ -222,13 +222,11 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):
"""
if self._tracing_backend is None:
self._tracing_backend = tracing_backend.TracingBackend(self._port)
- self._tracing_backend.BeginTracing(custom_categories, timeout)
+ return self._tracing_backend.StartTracing(custom_categories, timeout)
def StopTracing(self):
- self._tracing_backend.EndTracing()
-
- def GetTraceResultAndReset(self):
- return self._tracing_backend.GetTraceResultAndReset()
+ """ Stops tracing and returns the result as TraceResult object. """
+ return self._tracing_backend.StopTracing()
def GetProcessName(self, cmd_line):
"""Returns a user-friendly name for the process of the given |cmd_line|."""

Powered by Google App Engine
This is Rietveld 408576698