tools/perf/metrics/timeline.py - Issue 23902027: telemetry: Make trace profiler work with trace-based benchmarks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/timeline.py

Issue 23902027: telemetry: Make trace profiler work with trace-based benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add subset test for category filters. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/metrics/timeline.py

diff --git a/tools/perf/metrics/timeline.py b/tools/perf/metrics/timeline.py

index 646264699395124f9b11bb615e07bb672151950f..6d9ef26e8d82815210d8c5c4b951a7f8a0f60043 100644

--- a/tools/perf/metrics/timeline.py

+++ b/tools/perf/metrics/timeline.py

@@ -38,8 +38,7 @@ class TimelineMetric(Metric):

console.timeEnd("__loading_measurement_was_here__");

""")

- tab.browser.StopTracing()

- trace_result = tab.browser.GetTraceResultAndReset()

+ trace_result = tab.browser.StopTracing()

self._model = trace_result.AsTimelineModel()

events = [s for

s in self._model.GetAllEventsOfName(

@@ -68,4 +67,3 @@ class TimelineMetric(Metric):

results.Add(event_name, 'ms', total)

results.Add(event_name + '_max', 'ms', biggest_jank)

results.Add(event_name + '_avg', 'ms', total / len(times))

« no previous file with comments | « tools/perf/measurements/smoothness.py ('k') | tools/telemetry/telemetry/core/backends/browser_backend.py » ('j') | no next file with comments »