Fallback to GLES context when GL context setup fails at any stage.

Fallback to GLES context when GL context setup fails at any stage.

Committed: http://code.google.com/p/skia/source/detail?r=11135

[bsalomon, 2013-09-06 18:12:46]

This fixes the intel device.

[robertphillips, 2013-09-06 18:30:40]

lgtm + some questions

https://codereview.chromium.org/23902015/diff/1/src/gpu/gl/android/SkNativeGL...
File src/gpu/gl/android/SkNativeGLContext_android.cpp (right):

https://codereview.chromium.org/23902015/diff/1/src/gpu/gl/android/SkNativeGL...
src/gpu/gl/android/SkNativeGLContext_android.cpp:71:
kEGLContextAttribsForOpenGL,
Shouldn't this be EGL_OPENGL_BIT?

https://codereview.chromium.org/23902015/diff/1/src/gpu/gl/android/SkNativeGL...
src/gpu/gl/android/SkNativeGLContext_android.cpp:86: for (size_t api = 0; NULL
== interface && api < SK_ARRAY_COUNT(kAPIs); ++api) {
Does the Display setting need to be inside the loop? If so, is it indented
correctly?

https://codereview.chromium.org/23902015/diff/1/src/gpu/gl/android/SkNativeGL...
src/gpu/gl/android/SkNativeGLContext_android.cpp:117: SkDebugf("eglChooseConfig
failed. EGL Error: 0x%08x\n", eglGetError());
Not continue?

[bsalomon, 2013-09-06 18:47:36]

https://codereview.chromium.org/23902015/diff/1/src/gpu/gl/android/SkNativeGL...
File src/gpu/gl/android/SkNativeGLContext_android.cpp (right):

https://codereview.chromium.org/23902015/diff/1/src/gpu/gl/android/SkNativeGL...
src/gpu/gl/android/SkNativeGLContext_android.cpp:71:
kEGLContextAttribsForOpenGL,
On 2013/09/06 18:30:40, robertphillips wrote:
> Shouldn't this be EGL_OPENGL_BIT?

yes, nice catch.

https://codereview.chromium.org/23902015/diff/1/src/gpu/gl/android/SkNativeGL...
src/gpu/gl/android/SkNativeGLContext_android.cpp:86: for (size_t api = 0; NULL
== interface && api < SK_ARRAY_COUNT(kAPIs); ++api) {
On 2013/09/06 18:30:40, robertphillips wrote:
> Does the Display setting need to be inside the loop? If so, is it indented
> correctly?

Yes, only because destroyContext(), called below, sets it back to null.

https://codereview.chromium.org/23902015/diff/1/src/gpu/gl/android/SkNativeGL...
src/gpu/gl/android/SkNativeGLContext_android.cpp:117: SkDebugf("eglChooseConfig
failed. EGL Error: 0x%08x\n", eglGetError());
On 2013/09/06 18:30:40, robertphillips wrote:
> Not continue?

Done.

[commit-bot: I haz the power, 2013-09-06 18:47:53]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/23902015/5001

[commit-bot: I haz the power, 2013-09-06 18:57:18]

Change committed as 11135