Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 23902011: Use FavoriteList in ClientCertResolver instead of NetworkList (Closed)

Created:
7 years, 3 months ago by pneubeck (no reviews)
Modified:
7 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, gauravsh+watch_chromium.org, gspencer+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Use FavoriteList in ClientCertResolver instead of NetworkList This is required for EthernetEAP, because that one will not show up in the network list of NetworkStateHandler. BUG=126870 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M chromeos/network/client_cert_resolver.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/client_cert_resolver.cc View 4 chunks +13 lines, -20 lines 0 comments Download
M chromeos/network/favorite_state.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chromeos/network/favorite_state.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pneubeck (no reviews)
7 years, 3 months ago (2013-09-05 11:22:37 UTC) #1
stevenjb
lgtm
7 years, 3 months ago (2013-09-05 17:05:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/23902011/1
7 years, 3 months ago (2013-09-06 13:07:31 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 20:33:01 UTC) #4
Message was sent while issue was closed.
Change committed as 221772

Powered by Google App Engine
This is Rietveld 408576698