[Chrome OS MD] Update spacing between material design icons in the system tray

ash/common/system/tray/tray_constants.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_SYSTEM_TRAY_TRAY_CONSTANTS_H_
 #define ASH_COMMON_SYSTEM_TRAY_TRAY_CONSTANTS_H_
 
 #include "ash/ash_export.h"
 
 typedef unsigned int SkColor;
 
 namespace ash {
 
 extern const int kPaddingFromRightEdgeOfScreenBottomAlignment;
 extern const int kPaddingFromBottomOfScreenBottomAlignment;
 extern const int kPaddingFromOuterEdgeOfLauncherVerticalAlignment;
 extern const int kPaddingFromInnerEdgeOfLauncherVerticalAlignment;
 extern const int kPaddingFromBottomOfScreenVerticalAlignment;
 
 extern const int kBubblePaddingHorizontalBottom;
 extern const int kBubblePaddingHorizontalSide;
 extern const int kBubblePaddingVerticalBottom;
 extern const int kBubblePaddingVerticalSide;
 
 extern const int kTrayBubbleAnchorTopInsetBottomAnchor;
 
-extern const int kTrayImageItemHorizontalPaddingBottomAlignment;
 extern const int kTrayImageItemHorizontalPaddingVerticalAlignment;
-extern const int kTrayImageItemVerticalPaddingVerticalAlignment;
 
 ASH_EXPORT extern const int kTrayItemSize;
 
 extern const int kTrayLabelItemHorizontalPaddingBottomAlignment;
 extern const int kTrayLabelItemVerticalPaddingVerticalAlignment;
 
 extern const int kTrayMenuBottomRowPadding;
 extern const int kTrayMenuBottomRowPaddingBetweenItems;
 
 extern const int kTrayPopupAutoCloseDelayInSeconds;
@@ skipping 72 matching lines @@
   TRAY_POPUP_ITEM_HEIGHT,
 
   // The width and height of the virtual keyboard button in the status tray
   // area. For non-MD, adjustments are made to the button dimensions based on
   // the shelf orientation, so this constant does not specify the true
   // user-visible button bounds.
   VIRTUAL_KEYBOARD_BUTTON_SIZE,
 
   // The icon size of opt-in IME menu tray.
   TRAY_IME_MENU_ICON,
+
+  // The padding needed between 2 items in the tray area in the shelf.

[tdanderson, 2016/10/05 21:34:29]

The spec says we need a padding of 6 between two items. It looks like you're
using this to specify the padding on one side of a single icon (which would give
a total between-icon padding of 3+3=6). That's fine, but can you reword the
comment to something like "extra padding beside a single icon" instead of
"padding between two items"?

also, nit: 2 -> "two"

[yiyix, 2016/10/05 22:46:47]

Done.

+  TRAY_IMAGE_ITEM_PADDING,
 };
 
 int GetTrayConstant(TrayConstant constant);
 
 namespace test {
 const int kSettingsTrayItemViewId = 10000;
 const int kAccessibilityTrayItemViewId = 10001;
 }  // namespace test
 
 }  // namespace ash
 
 #endif  // ASH_COMMON_SYSTEM_TRAY_TRAY_CONSTANTS_H_