Source/bindings/dart/DartNativeUtilities.cpp - Issue 23895004: Keep a persistent handle for the bindings classes to avoid repeated lookups that involve performing…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/dart/DartNativeUtilities.cpp

Issue 23895004: Keep a persistent handle for the bindings classes to avoid repeated lookups that involve performing… (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit

Patch Set: . Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/dart/DartNativeUtilities.cpp

diff --git a/Source/bindings/dart/DartNativeUtilities.cpp b/Source/bindings/dart/DartNativeUtilities.cpp

index feec90f5e6cf801cc7a28ee36916a1e9cd9e6865..5cd55b9a617a72f1db0bec0ccbc44546d0791047 100644

--- a/Source/bindings/dart/DartNativeUtilities.cpp

+++ b/Source/bindings/dart/DartNativeUtilities.cpp

@@ -140,7 +140,7 @@ static void npObjectRetrieve(Dart_NativeArguments args)

NPObject* npObject = controller->npObject(key);

if (npObject) {

// FIXME: put NPObjects into a map as well.

- Dart_SetReturnValue(args, DartDOMWrapper::newWrapper("_NPObject", DartUtilities::htmlLibraryName, npObject));

+ Dart_SetReturnValue(args, DartDOMWrapper::newWrapper("_NPObject", DartUtilities::htmlLibraryName, _NPObjectClassId, npObject));

}

return;

}

« no previous file with comments | « Source/bindings/dart/DartDOMWrapper.cpp ('k') | Source/bindings/dart/DartUtilities.h » ('j') | no next file with comments »