Keep a persistent handle for the bindings classes to avoid repeated lookups that involve performing…

Source/bindings/dart/DartDOMWrapper.h

 // Copyright 2011, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //    * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //    * Redistributions in binary form must reproduce the above
@@ skipping 33 matching lines @@
 #include <wtf/text/AtomicString.h>
 #include <wtf/text/WTFString.h>
 
 namespace WebCore {
 
 template<class BindingsClass>
 struct DartDOMWrapperTraits;
 
 class DartDOMWrapper {
 public:
+    enum {
+        DOMStringMapBindingCid = 0,
+        NumCustomBindingCids
+    };
+
     template <class WebKitClass>
     static Dart_Handle newWrapper(const char* className, const char* libraryName, WebKitClass* domObject)
     {
         Dart_Handle wrapper = instantiateWrapper(className, libraryName);
         writeNativePointer(wrapper, kNativeImplementationIndex, domObject);
         return wrapper;
     }
 
     template <class BindingsClass>
     static Dart_Handle toDart(typename BindingsClass::NativeType* domObject)
@@ skipping 105 matching lines @@
     }
 
     template <class BindingsClass>
     static typename BindingsClass::NativeType* unwrapDartWrapper(Dart_NativeArguments args, int index, Dart_Handle& exception)
     {
         ASSERT(!exception);
         Dart_Handle wrapper = Dart_GetNativeArgument(args, index);
         return unwrapDartWrapper<BindingsClass>(wrapper, exception);
     }
 
+    static intptr_t nextClassIndex;

[siva, 2013/09/10 00:18:50]

Not used anymore right, could be deleted.

[rmacnak, 2013/09/10 20:09:51]

Removed.

+
     template <class BindingsClass>
     static bool instanceOf(Dart_Handle wrapper)
     {
-        return instanceOf(BindingsClass::dartImplementationClassName, BindingsClass::dartImplementationLibraryName, wrapper);
+        Dart_Handle type = dartClass<BindingsClass>();
+
+        bool isInstanceOf = false;
+        Dart_Handle result = Dart_ObjectIsType(wrapper, type, &isInstanceOf);
+        ASSERT(!Dart_IsError(result));
+        if (Dart_IsError(result))
+            return false;

[siva, 2013/09/10 00:18:50]

Seems to assert and check, I think the ASSERT is not needed.

[rmacnak, 2013/09/10 20:09:51]

Removed.

+        return isInstanceOf;
+    }
+
+    template <class BindingsClass>
+    static Dart_Handle dartClass()

[siva, 2013/09/10 00:18:50]

This can also be private right.

[rmacnak, 2013/09/10 20:09:51]

Hidden.

+    {
+        return dartClass(BindingsClass::dartImplementationClassName, BindingsClass::dartImplementationLibraryName, BindingsClass::kBindingCid);
     }
 
     template <class WebKitClass>
     static WebKitClass* receiver(Dart_NativeArguments args)
     {
         // Type of receiver is ensured by Dart VM runtime, so bypass additional checks.
         intptr_t value = 0;
         ASSERT(!kNativeImplementationIndex);
         Dart_Handle result = Dart_GetNativeReceiver(args, &value);
         ASSERT(!Dart_IsError(result));
@@ skipping 21 matching lines @@
     static Dart_Handle exceptionCodeToDartException(ExceptionCode);
     static Dart_Handle exceptionCodeToDartException(DartExceptionState&);
 
 private:
     enum NativeFieldIndices {
         kNativeImplementationIndex = 0,
         kNativeFieldCount
     };
 
     static Dart_Handle instantiateWrapper(const char* className, const char* libraryName);
-    static bool instanceOf(const char* dartImplementationClassName,
-            const char* dartImplementationLibraryName, Dart_Handle wrapper);
+    static Dart_Handle dartClass(const char* dartImplementationClassName,
+        const char* dartImplementationLibraryName, intptr_t classIndex);
 
     static void writeNativePointer(Dart_Handle wrapper, int index, void* pointer)
     {
         DartApiScope scope;
         Dart_Handle result = Dart_SetNativeInstanceField(wrapper, index, reinterpret_cast<intptr_t>(pointer));
         UNUSED_PARAM(result);
         ASSERT(!Dart_IsError(result));
     }
 
     static void* readNativePointer(Dart_Handle wrapper, int index)
@@ skipping 98 matching lines @@
         static DartMessagePortMap* domMap(DartDOMData* domData) { return domData->messagePortMap(); }
     };
     typedef MessagePortMapTraits MapTraits;
     typedef DartDOMWrapperActiveTraits<DartMessagePort, false> ActiveTraits;
     typedef DartDOMWrapperEventTargetTraits<DartMessagePort, true> EventTargetTraits;
 };
 
 }
 
 #endif // DartDOMWrapper_h