Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Side by Side Diff: Source/bindings/dart/custom/DartWindowCustom.cpp

Issue 23895004: Keep a persistent handle for the bindings classes to avoid repeated lookups that involve performing… (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: . Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/dart/custom/DartDOMStringMapCustom.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011, Google Inc. 1 // Copyright 2011, Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 // FIXME: proper implementation. 62 // FIXME: proper implementation.
63 DART_UNIMPLEMENTED(); 63 DART_UNIMPLEMENTED();
64 } 64 }
65 65
66 void historyCrossFrameGetter(Dart_NativeArguments args) 66 void historyCrossFrameGetter(Dart_NativeArguments args)
67 { 67 {
68 { 68 {
69 DOMWindow* receiver = DartDOMWrapper::receiver<DOMWindow>(args); 69 DOMWindow* receiver = DartDOMWrapper::receiver<DOMWindow>(args);
70 70
71 Dart_Handle result = DartDOMWrapper::toDartWithClassName<DartHistory>( 71 Dart_Handle result = DartDOMWrapper::toDartWithClassName<DartHistory>(
72 receiver->history(), "_HistoryCrossFrame", DartUtilities::htmlLibrar yName); 72 receiver->history(), "_HistoryCrossFrame", DartUtilities::htmlLibrar yName, _HistoryCrossFrameClassId);
73 if (result) 73 if (result)
74 Dart_SetReturnValue(args, result); 74 Dart_SetReturnValue(args, result);
75 } 75 }
76 } 76 }
77 77
78 void locationCrossFrameGetter(Dart_NativeArguments args) 78 void locationCrossFrameGetter(Dart_NativeArguments args)
79 { 79 {
80 { 80 {
81 DOMWindow* receiver = DartDOMWrapper::receiver<DOMWindow>(args); 81 DOMWindow* receiver = DartDOMWrapper::receiver<DOMWindow>(args);
82 82
83 Dart_Handle result = DartDOMWrapper::toDartWithClassName<DartLocation>( 83 Dart_Handle result = DartDOMWrapper::toDartWithClassName<DartLocation>(
84 receiver->location(), "_LocationCrossFrame", DartUtilities::htmlLibr aryName); 84 receiver->location(), "_LocationCrossFrame", DartUtilities::htmlLibr aryName, _LocationCrossFrameClassId);
85 if (result) 85 if (result)
86 Dart_SetReturnValue(args, result); 86 Dart_SetReturnValue(args, result);
87 } 87 }
88 } 88 }
89 89
90 void locationSetter(Dart_NativeArguments args) 90 void locationSetter(Dart_NativeArguments args)
91 { 91 {
92 Dart_Handle exception = 0; 92 Dart_Handle exception = 0;
93 { 93 {
94 DOMWindow* receiver = DartDOMWrapper::receiver<DOMWindow>(args); 94 DOMWindow* receiver = DartDOMWrapper::receiver<DOMWindow>(args);
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 void ___getter___2Callback(Dart_NativeArguments) 298 void ___getter___2Callback(Dart_NativeArguments)
299 { 299 {
300 // FIXME: proper implementation. 300 // FIXME: proper implementation.
301 DART_UNIMPLEMENTED(); 301 DART_UNIMPLEMENTED();
302 } 302 }
303 303
304 } 304 }
305 305
306 Dart_Handle DartWindow::toDart(DOMWindow* window) 306 Dart_Handle DartWindow::toDart(DOMWindow* window)
307 { 307 {
308 return DartDOMWrapper::toDartWithClassName<DartWindow>(window, "_DOMWindowCr ossFrame", DartUtilities::htmlLibraryName); 308 return DartDOMWrapper::toDartWithClassName<DartWindow>(window, "_DOMWindowCr ossFrame", DartUtilities::htmlLibraryName, _DOMWindowCrossFrameClassId);
309 } 309 }
310 310
311 } 311 }
OLDNEW
« no previous file with comments | « Source/bindings/dart/custom/DartDOMStringMapCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698