Keep a persistent handle for the bindings classes to avoid repeated lookups that involve performing…

Source/bindings/dart/DartDOMWrapper.cpp

 // Copyright 2011, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //    * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //    * Redistributions in binary form must reproduce the above
@@ skipping 25 matching lines @@
 #include "DartNode.h"
 #include "bindings/dart/DartUtilities.h"
 #include "core/html/HTMLFormControlElement.h"
 #include "core/html/LabelableElement.h"
 
 #include <stdio.h>
 #include <wtf/text/WTFString.h>
 
 namespace WebCore {
 
-Dart_Handle DartDOMWrapper::instantiateWrapper(const char* className, const char* libraryName)
+Dart_Handle DartDOMWrapper::dartClass(const char* className, const char* libraryName, intptr_t index)
 {
-    Dart_Handle library = DartUtilities::libraryForCurrentIsolate(libraryName);
-    ASSERT(!Dart_IsError(library));
+    ClassTable* table = DartDOMData::current()->classHandleCache();
 
-    Dart_Handle type = Dart_GetType(library, Dart_NewStringFromCString(className), 0, 0);
-    ASSERT(!Dart_IsError(type));
+    Dart_Handle type;
+    Dart_PersistentHandle persistentType;

[siva, 2013/09/12 18:33:34]

ASSERT(index < kNumWebKitClassIds);

 
-    Dart_Handle instance = Dart_Allocate(type);
-    ASSERT(!Dart_IsError(instance));
+    if ((*table)[index]) {
+        persistentType = (*table)[index];
+        type = Dart_HandleFromPersistent(persistentType);
+    } else {
+        Dart_Handle library = DartUtilities::libraryForCurrentIsolate(libraryName);
+        ASSERT(!Dart_IsError(library));
 
-    return instance;
-}
+        type = Dart_GetType(library, Dart_NewStringFromCString(className), 0, 0);
+        ASSERT(!Dart_IsError(type));
 
-bool DartDOMWrapper::instanceOf(const char* className, const char* libraryName, Dart_Handle wrapper)
-{
-    // FIXME(rmacnak): Cache classes in the corresponding bindings class. Requires persistent handles.
-    Dart_Handle library = DartUtilities::libraryForCurrentIsolate(libraryName);
-    ASSERT(!Dart_IsError(library));
+        persistentType = Dart_NewPersistentHandle(type);
+        (*table)[index] = persistentType;
+    }

[siva, 2013/09/12 18:33:34]

Maybe structure this code as:

persistentType = (*table)[index];
if (persistentType) {
  type = Dart_handleFromPersistent(persistentType);
} else {
  .....
  .....
}
return type;

 
-    Dart_Handle type = Dart_GetType(library, Dart_NewStringFromCString(className), 0, 0);
-    ASSERT(!Dart_IsError(type));
-    if (Dart_IsError(type))
-        return false;
-
-    bool isInstanceOf = false;
-    Dart_Handle result = Dart_ObjectIsType(wrapper, type, &isInstanceOf);
-    ASSERT(!Dart_IsError(result));
-    if (Dart_IsError(result))
-        return false;
-    return isInstanceOf;
+    return type;
 }
 
 Dart_Handle DartDOMWrapper::exceptionCodeToDartException(ExceptionCode exceptionCode)
 {
     ASSERT(exceptionCode > 0);
 
     // FIXME: Get a better exception message here.
     RefPtr<DOMException> domException = DOMException::create(exceptionCode, "Internal Dartium Exception");
 
     return DartDOMException::toDart(domException);
 }
 
 Dart_Handle DartDOMWrapper::exceptionCodeToDartException(DartExceptionState& exceptionState)
 {
     return exceptionCodeToDartException(exceptionState.code());
 }
 
 }