Start Alt+Tab on MRU instead of MRU+1 if all windows are minimized.

ash/wm/window_cycle_controller_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/wm/window_cycle_controller.h"
 
 #include <algorithm>
 #include <memory>
 
 #include "ash/aura/wm_window_aura.h"
@@ skipping 277 matching lines @@
   EXPECT_FALSE(window0_state->IsActive());
   EXPECT_FALSE(window1_state->IsMinimized());
   EXPECT_TRUE(window1_state->IsActive());
 
   // One more time back to w0.
   controller->HandleCycleWindow(WindowCycleController::FORWARD);
   controller->StopCycling();
   EXPECT_TRUE(window0_state->IsActive());
 }
 
+// If all windows are minimized, start on the first one rather than the second

[varkha, 2016/10/06 03:31:08]

Nit: "Tests that when all windows are minimized, cycling starts with the first
one rather than the second".

[Evan Stade, 2016/10/06 15:40:33]

Done.

+// one.
+TEST_F(WindowCycleControllerTest, AllAreMinimized) {
+  // Create a couple of test windows.
+  std::unique_ptr<Window> window0(CreateTestWindowInShellWithId(0));
+  std::unique_ptr<Window> window1(CreateTestWindowInShellWithId(1));
+  wm::WindowState* window0_state = wm::GetWindowState(window0.get());
+  wm::WindowState* window1_state = wm::GetWindowState(window1.get());
+
+  window0_state->Minimize();
+  window1_state->Minimize();
+
+  WindowCycleController* controller = WmShell::Get()->window_cycle_controller();
+  controller->HandleCycleWindow(WindowCycleController::FORWARD);
+  controller->StopCycling();
+  EXPECT_TRUE(window0_state->IsActive());
+  EXPECT_FALSE(window0_state->IsMinimized());
+  EXPECT_TRUE(window1_state->IsMinimized());
+
+  // But it's business as usual when cycling backwards.
+  window0_state->Minimize();
+  window1_state->Minimize();

[varkha, 2016/10/06 03:31:08]

Redundant?

[Evan Stade, 2016/10/06 15:40:33]

seems harmless but improves legibility

+  controller->HandleCycleWindow(WindowCycleController::BACKWARD);
+  controller->StopCycling();
+  EXPECT_TRUE(window0_state->IsMinimized());
+  EXPECT_TRUE(window1_state->IsActive());
+  EXPECT_FALSE(window1_state->IsMinimized());
+}
+
 TEST_F(WindowCycleControllerTest, AlwaysOnTopWindow) {
   WindowCycleController* controller = WmShell::Get()->window_cycle_controller();
 
   // Set up several windows to use to test cycling.
   std::unique_ptr<Window> window0(CreateTestWindowInShellWithId(0));
   std::unique_ptr<Window> window1(CreateTestWindowInShellWithId(1));
 
   Window* top_container = Shell::GetContainer(
       Shell::GetPrimaryRootWindow(), kShellWindowId_AlwaysOnTopContainer);
   std::unique_ptr<Window> window2(CreateTestWindowWithId(2, top_container));
@@ skipping 355 matching lines @@
   // without the new alt+tab selector we check for the event on either
   // fullscreen window.
   EventCounter event_count;
   w0->AddPreTargetHandler(&event_count);
   w1->AddPreTargetHandler(&event_count);
   generator.PressKey(ui::VKEY_TAB, ui::EF_ALT_DOWN);
   EXPECT_EQ(1, event_count.GetKeyEventCountAndReset());
 }
 
 }  // namespace ash