Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23892008: Move VolumeManager to c/b/chromeos/file_manager (Closed)

Created:
7 years, 3 months ago by hidehiko
Modified:
7 years, 3 months ago
Reviewers:
satorux1
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move VolumeManager to c/b/chromeos/file_manager This is remaining part of r221334, because during its code review, VolumeManager was actively being changed so that it was kept as is to avoid conflict. BUG=273386 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1080 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/event_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/volume_manager.h View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/volume_manager.cc View 1 chunk +0 lines, -246 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/volume_manager_factory.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/volume_manager_factory.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/volume_manager_observer.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_manager/volume_manager_unittest.cc View 1 chunk +0 lines, -541 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/volume_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/volume_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/volume_manager_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/volume_manager_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/volume_manager_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/file_manager/volume_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
hidehiko
PTAL?
7 years, 3 months ago (2013-09-06 04:43:17 UTC) #1
satorux1
LGTM
7 years, 3 months ago (2013-09-06 04:47:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23892008/1
7 years, 3 months ago (2013-09-06 04:48:27 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 08:40:14 UTC) #4
Message was sent while issue was closed. 
Change committed as 221650

Powered by Google App Engine
This is Rietveld 408576698