Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 23892006: Allows focus to change when capture held (Closed)

Created:
7 years, 3 months ago by sky
Modified:
7 years, 3 months ago
Reviewers:
ananta
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Allows focus to change when capture held r186536 made it so focus focus changes while capture held are ignored. Problem is we enter this scenario when activating a window. In particular the window has capture, then we activate it but the activation is ignored because it has capture. In this case we need to allow the focus change else events are completely dropped. BUG=277593 TEST=covered by tests R=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M ui/views/corewm/focus_controller.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/views/corewm/focus_controller_unittest.cc View 4 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
7 years, 3 months ago (2013-09-05 15:05:57 UTC) #1
ananta
lgtm
7 years, 3 months ago (2013-09-05 18:01:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/23892006/1
7 years, 3 months ago (2013-09-05 20:06:49 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 08:22:05 UTC) #4
Message was sent while issue was closed.
Change committed as 221645

Powered by Google App Engine
This is Rietveld 408576698