Fix OAuth "trampoline" content script to send a message with the oauth results rather than using a …

Fix OAuth "trampoline" content script to send a message with the oauth results rather than using a redirect into the extension.

BUG=291207
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224474

[rmsousa, 2013-09-19 01:41:32]

This needs to open a new window, as the extension must be open somewhere to
listen and receive the message (also, so we're able to get back to it). I'm
using the same decorations I use with third_party_auth, which are tuned to mimic
the exact look of the identity api launchWebAuth window.

The nice part is that this removes the one last place where we reloaded the
webapp.

Note: I had to remove a couple methods from jscompiler_hacks.js to get it to
jscompile cleanly, since they were redundant with the ones defined in
chrome_extensions.js (from your jscompile setup).

[Jamie, 2013-09-19 17:06:11]

lgtm

[alexeypa (please no reviews), 2013-09-19 18:14:00]

On 2013/09/19 17:06:11, Jamie wrote:
> lgtm

I noticed (after applying this CL) that the list of hosts is not updated when
switching between different users. I.e.:

1. Click on Sign out.
2. Select a different user.
3. Accept permissions.
4. At this point the list of host for the new user should show up, bu instead
the old list of host is shown.

[Jamie, 2013-09-19 18:17:16]

On 2013/09/19 18:14:00, alexeypa wrote:
> On 2013/09/19 17:06:11, Jamie wrote:
> > lgtm
> 
> I noticed (after applying this CL) that the list of hosts is not updated when
> switching between different users. I.e.:
> 
> 1. Click on Sign out.
> 2. Select a different user.
> 3. Accept permissions.
> 4. At this point the list of host for the new user should show up, bu instead
> the old list of host is shown.

Good catch! That will be a side-effect of not reloading the app. Adding a call
to refresh+display after the OAuth bounce should resolve that. Renato, please
consider my LGTM to be contingent on adding that.

[commit-bot: I haz the power, 2013-09-19 22:29:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rmsousa@chromium.org/23891005/7001

[commit-bot: I haz the power, 2013-09-20 00:32:46]

Retried try job too often on win_rel for step(s) content_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-09-20 19:10:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rmsousa@chromium.org/23891005/7001

[commit-bot: I haz the power, 2013-09-20 20:23:01]

Change committed as 224474