Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 23890043: Update image content rect on src changes even if intrinsic size matches (Closed)

Created:
7 years, 3 months ago by pdr.
Modified:
7 years, 2 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Update image content rect on src changes even if intrinsic size matches This patch changes RenderImage::imageDimensionsChanged to update the image content rect even if the image's intrinsic size is equal. This fixes a bug where changing an SVG image to another image of the same size would not correctly update the image content rect. This patch also cleans up a confusing variable name in RenderImage::updateInnerContentRect, changing paint rect to container rect to better match what it is. BUG=269946 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158343

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -10 lines) Patch
A LayoutTests/svg/as-image/image-change-with-equal-sizes.html View 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-image/image-change-with-equal-sizes-expected.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-image/resources/200x200-blue-rect.svg View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pdr.
7 years, 3 months ago (2013-09-24 06:36:21 UTC) #1
f(malita)
lgtm
7 years, 2 months ago (2013-09-25 19:47:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/23890043/1
7 years, 2 months ago (2013-09-25 19:47:39 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-09-26 00:52:02 UTC) #4
Message was sent while issue was closed.
Change committed as 158343

Powered by Google App Engine
This is Rietveld 408576698