Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 23890020: Don't use COPY_PHASE_STRIP (Closed)

Created:
7 years, 3 months ago by Mark Mentovai
Modified:
7 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Don't use COPY_PHASE_STRIP. For Mac builds, things that need to strip do it when they build. BUG=280718 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Mentovai
7 years, 3 months ago (2013-09-12 23:15:47 UTC) #1
Nico
lgtm, yay! Maybe add 280718 in a BUG= line since it's marginally related to that.
7 years, 3 months ago (2013-09-12 23:16:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mark@chromium.org/23890020/1
7 years, 3 months ago (2013-09-12 23:23:39 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-13 02:22:33 UTC) #4
Message was sent while issue was closed.
Change committed as 222961

Powered by Google App Engine
This is Rietveld 408576698