Issue 23890011: rAc: revert 3 second dismissal immunity on generated card bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23890011: rAc: revert 3 second dismissal immunity on generated card bubble (Closed)

Created:
7 years, 3 months ago by Evan Stade

Modified:
7 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, benquan, tfarina, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

rAc: revert 3 second dismissal immunity on generated card bubble BUG=282671 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221851

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -22 lines)			Patch
	M	chrome/browser/ui/views/autofill/generated_credit_card_bubble_views.h	View		2 chunks	+0 lines, -7 lines	0 comments	Download
	M	chrome/browser/ui/views/autofill/generated_credit_card_bubble_views.cc	View		2 chunks	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

Apparently, we don't want this after all. At least those tests got moved to a ...

7 years, 3 months ago (2013-09-06 21:46:33 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/23890011/1

7 years, 3 months ago (2013-09-06 22:24:35 UTC) #3

Message was sent while issue was closed.

Change committed as 221851

Expand Messages | Collapse Messages