Extract OnDiskEvent and OnFormatEvent logic part from EventRouter to VolumeManager.

Extract OnDiskEvent and OnFormatEvent logic part from EventRouter to VolumeManager.

This CL extracts non-notification-related logics from EventRouter and move it
to the VolumeManager.
Now, EventRouter::OnDiskAdded, OnDiskRemoved, OnFormatStarted and
OnFormatCompleted focus on event routing, and VolumeManager has responsibility
of other stuff.

BUG=279276
TEST=Ran unit_tests and tested manually.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221407

[hidehiko, 2013-09-03 11:22:18]

Thank you for your review in advance,
- hidehiko

[hidehiko, 2013-09-04 08:03:26]

friendly ping?

[kinaba, 2013-09-04 08:48:47]

lgtm

[hidehiko, 2013-09-04 15:51:08]

On 2013/09/04 08:48:47, kinaba wrote:
> lgtm

Kazuhiro, sorry that I overlooked there is browser test for event_router, and
this CL breaks it.
The current test is only for making sure what VolumeManager handles in new code,
so I think it's time to add unit_tests for VolumeManager.
Could you kindly take another look?

Thank you for your help!
- hidehiko

[kinaba, 2013-09-05 08:51:52]

LGTM!

[commit-bot: I haz the power, 2013-09-05 08:53:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23890002/17001

[commit-bot: I haz the power, 2013-09-05 08:54:02]

Failed to apply patch for chrome/chrome_tests.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/chrome_tests.gypi
  Hunk #1 FAILED at 1217.
  1 out of 1 hunk FAILED -- saving rejects to file chrome/chrome_tests.gypi.rej

Patch:       chrome/chrome_tests.gypi
Index: chrome/chrome_tests.gypi
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index
d85ffacc0dc75ce9f7eb1e65346346dff88d0a61..6c1533f3b9ff7dba2a0b63f542f060fc6b5e61e1
100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -1217,7 +1217,6 @@
        
'browser/chromeos/extensions/file_manager/desktop_notifications_browsertest.cc',
         'browser/chromeos/extensions/file_manager/drive_test_util.cc',
         'browser/chromeos/extensions/file_manager/drive_test_util.h',
-        'browser/chromeos/extensions/file_manager/event_router_browsertest.cc',
        
'browser/chromeos/extensions/file_manager/external_filesystem_apitest.cc',
        
'browser/chromeos/extensions/file_manager/file_browser_handler_api_test.cc',
        
'browser/chromeos/extensions/file_manager/file_browser_private_apitest.cc',

[commit-bot: I haz the power, 2013-09-05 09:10:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23890002/37001

[commit-bot: I haz the power, 2013-09-05 13:27:59]

Change committed as 221407