Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: scripts/slave/recipe_modules/git/example.py

Issue 23889036: Refactor the way that TestApi works so that it is actually useful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/git/example.py
diff --git a/scripts/slave/recipe_modules/git/example.py b/scripts/slave/recipe_modules/git/example.py
index 77503866b13214b403adc4d60525bc543197ca99..fd31331f9d813cb08fe477839be05875c69c608d 100644
--- a/scripts/slave/recipe_modules/git/example.py
+++ b/scripts/slave/recipe_modules/git/example.py
@@ -5,6 +5,7 @@
DEPS = [
'git',
'path',
+ 'platform',
]
@@ -19,13 +20,7 @@ def GenSteps(api):
yield api.git.command('status', cwd=api.path.checkout())
-def GenTests(_api):
- yield 'basic', {}
+def GenTests(api):
+ yield api.Test('basic')
- yield 'platform_win', {
- 'mock': {
- 'platform': {
- 'name': 'win'
- }
- }
- }
+ yield api.Test('platform_win') + api.platform.name('win')

Powered by Google App Engine
This is Rietveld 408576698