Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: scripts/slave/recipe_modules/android/api.py

Issue 23889036: Refactor the way that TestApi works so that it is actually useful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/android/api.py
diff --git a/scripts/slave/recipe_modules/android/api.py b/scripts/slave/recipe_modules/android/api.py
index e47ec0e529d9ecbf2a81d244c7aec26bc86c9e5d..b7462d1e93908d35d850e207eb6de6fbddc97271 100644
--- a/scripts/slave/recipe_modules/android/api.py
+++ b/scripts/slave/recipe_modules/android/api.py
@@ -34,6 +34,19 @@ class AOSPApi(recipe_api.RecipeApi):
self.build_path,
self.c.lunch_flavor]
+ @recipe_api.inject_test_data
+ def calculate_trimmed_deps(self):
+ return self.m.step(
+ 'calculate trimmed deps',
+ [
+ self.m.path.checkout('android_webview', 'buildbot',
+ 'deps_whitelist.py'),
+ '--method', 'android_build',
+ '--path-to-deps', self.m.path.checkout('DEPS'),
+ self.m.json.output()
+ ],
+ )
+
def chromium_with_trimmed_deps(self, use_revision=True):
svn_revision = None
if use_revision and 'revision' in self.m.properties:
@@ -44,12 +57,7 @@ class AOSPApi(recipe_api.RecipeApi):
self.m.gclient.spec_alias = 'empty_deps'
yield self.m.gclient.checkout(spec)
- yield self.m.step(
- 'calculate trimmed deps',
- [self.m.path.checkout('android_webview', 'buildbot', 'deps_whitelist.py'),
- '--method', 'android_build',
- '--path-to-deps', self.m.path.checkout('DEPS'),
- self.m.json.output()])
+ yield self.calculate_trimmed_deps()
spec = self.m.gclient.make_config('chromium_bare')
deps_blacklist = self.m.step_history.last_step().json.output['blacklist']

Powered by Google App Engine
This is Rietveld 408576698