scripts/slave/recipes/run_presubmit.py - Issue 23889036: Refactor the way that TestApi works so that it is actually useful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/run_presubmit.py

Issue 23889036: Refactor the way that TestApi works so that it is actually useful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: License headers Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/run_presubmit.py

diff --git a/scripts/slave/recipes/run_presubmit.py b/scripts/slave/recipes/run_presubmit.py

index c65ddce82e720796b2973b5a5522ecb5618d42ba..b70d4721213eafc03f33bdbd44a600a3e28ea193 100644

--- a/scripts/slave/recipes/run_presubmit.py

+++ b/scripts/slave/recipes/run_presubmit.py

@@ -50,14 +50,11 @@ def GenSteps(api):

def GenTests(api):

for repo_name in ['blink', 'blink_bare', 'tools_build', 'chromium']:

+ extra = {}

if 'blink' in repo_name:

- props = api.properties_tryserver(

- root='src/third_party/WebKit'

- )

- else:

- props = api.properties_tryserver()

- props['repo_name'] = repo_name

- yield repo_name, {

- 'properties': props

- }

+ extra['root'] = 'src/third_party/WebKit'

+ yield (

+ api.test(repo_name) +

+ api.properties.tryserver(repo_name=repo_name, **extra)

+ )

« no previous file with comments | « scripts/slave/recipes/polymer.py ('k') | scripts/slave/recipes/v8.py » ('j') | no next file with comments »