Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: scripts/slave/recipes/chromium.py

Issue 23889036: Refactor the way that TestApi works so that it is actually useful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: License headers Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'chromium', 6 'chromium',
7 'gclient', 7 'gclient',
8 'platform',
8 'properties', 9 'properties',
9 'python', 10 'python',
10 ] 11 ]
11 12
12 def GenSteps(api): 13 def GenSteps(api):
13 # TODO(iannucci): Make a standard way to specify configuration in the recipe 14 # TODO(iannucci): Make a standard way to specify configuration in the recipe
14 # inputs. Such a design should be able to accept modified 15 # inputs. Such a design should be able to accept modified
15 # config blobs as well (hopefully readably delta-encoded). 16 # config blobs as well (hopefully readably delta-encoded).
16 config_vals = {'GIT_MODE': True} 17 config_vals = {'GIT_MODE': True}
17 config_vals.update( 18 config_vals.update(
18 dict((str(k),v) for k,v in api.properties.iteritems() if k.isupper()) 19 dict((str(k),v) for k,v in api.properties.iteritems() if k.isupper())
19 ) 20 )
20 api.chromium.set_config('chromium', **config_vals) 21 api.chromium.set_config('chromium', **config_vals)
21 22
22 yield ( 23 yield (
23 api.gclient.checkout(), 24 api.gclient.checkout(),
24 api.chromium.runhooks(), 25 api.chromium.runhooks(),
25 api.chromium.compile(), 26 api.chromium.compile(),
26 ) 27 )
27 28
28 yield api.python.inline('last step', 'print "last step"') 29 yield api.python.inline('last step', 'print "last step"')
29 30
30 31
31 def GenTests(api): 32 def GenTests(api):
32 for plat in ('win', 'mac', 'linux'): 33 for plat in ('win', 'mac', 'linux'):
33 for bits in (32, 64): 34 for bits in (32, 64):
34 yield 'basic_%s_%s' % (plat, bits), { 35 yield (
35 'mock': {'platform': {'name': plat}}, 36 api.test('basic_%s_%s' % (plat, bits)) +
36 'properties': {'TARGET_BITS': bits}, 37 api.properties(TARGET_BITS=bits) +
37 } 38 api.platform(plat, bits)
38 yield 'fail', { 39 )
39 'step_mocks': { 40 yield api.test('fail') + api.step_data('compile', retcode=1)
40 'compile': {
41 '$R': 1
42 }
43 }
44 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698