Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 23889022: Fix icu compilation on VS2013 (Closed)

Created:
7 years, 3 months ago by scottmg
Modified:
7 years, 3 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews
Visibility:
Public.

Description

Fix icu compilation on VS2013 (And move .patch file which was accidentally in the root). R=jshin@chromium.org BUG=288948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
A patches/vs2012.patch View 1 chunk +29 lines, -0 lines 0 comments Download
M source/common/stringpiece.cpp View 1 chunk +1 line, -1 line 0 comments Download
D vs2012.patch View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
7 years, 3 months ago (2013-09-12 23:55:12 UTC) #1
jungshik at Google
On 2013/09/12 23:55:12, scottmg wrote: LGTM
7 years, 3 months ago (2013-09-16 19:31:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/23889022/1
7 years, 3 months ago (2013-09-16 19:49:20 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 19:49:35 UTC) #4
Message was sent while issue was closed.
Change committed as 223384

Powered by Google App Engine
This is Rietveld 408576698