Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 23889021: Parent SSL certs window properly in win aura (Closed)

Created:
7 years, 3 months ago by scottmg
Modified:
7 years, 3 months ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org
Visibility:
Public.

Description

Parent SSL certs window properly in win aura Otherwise, parent window can be interacted with which causes redraw problems. R=estade@chromium.org BUG=284368 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223395

Patch Set 1 #

Total comments: 2

Patch Set 2 : no ifdef required #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/browser/ui/webui/options/advanced_options_utils_win.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scottmg
7 years, 3 months ago (2013-09-12 21:04:31 UTC) #1
scottmg
oops, looks like James is busy with a kid. +estade
7 years, 3 months ago (2013-09-13 16:40:05 UTC) #2
Evan Stade
ownership rslgtm, but I would rather you got someone else to give an actual review ...
7 years, 3 months ago (2013-09-13 20:27:54 UTC) #3
scottmg
thanks +sky for higher up aura review
7 years, 3 months ago (2013-09-13 20:29:03 UTC) #4
sky
https://codereview.chromium.org/23889021/diff/1/chrome/browser/ui/webui/options/advanced_options_utils_win.cc File chrome/browser/ui/webui/options/advanced_options_utils_win.cc (right): https://codereview.chromium.org/23889021/diff/1/chrome/browser/ui/webui/options/advanced_options_utils_win.cc#newcode66 chrome/browser/ui/webui/options/advanced_options_utils_win.cc:66: #if defined(USE_AURA) Can you use views::HWNDForNativeView to avoid the ...
7 years, 3 months ago (2013-09-16 16:59:29 UTC) #5
scottmg
https://codereview.chromium.org/23889021/diff/1/chrome/browser/ui/webui/options/advanced_options_utils_win.cc File chrome/browser/ui/webui/options/advanced_options_utils_win.cc (right): https://codereview.chromium.org/23889021/diff/1/chrome/browser/ui/webui/options/advanced_options_utils_win.cc#newcode66 chrome/browser/ui/webui/options/advanced_options_utils_win.cc:66: #if defined(USE_AURA) On 2013/09/16 16:59:29, sky wrote: > Can ...
7 years, 3 months ago (2013-09-16 17:26:38 UTC) #6
sky
LGTM
7 years, 3 months ago (2013-09-16 17:33:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/23889021/11001
7 years, 3 months ago (2013-09-16 17:35:26 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 20:19:51 UTC) #9
Message was sent while issue was closed.
Change committed as 223395

Powered by Google App Engine
This is Rietveld 408576698