Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 23889009: Initial Geolocation Wifi Scan Checking Fix for CrOS (Closed)

Created:
7 years, 3 months ago by robliao
Modified:
7 years, 3 months ago
CC:
vadimt, skare_, rgustafson, chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Initial Geolocation Wifi Scan Checking Fix for CrOS The ChromeOS Wifi provider was erronously reporting an initial scan of 0 wifi access points when the shill's scanning had not yet completed. This resulted in a fallback to IP geo for the first request and then proper Wifi based location on the second request. BUG=236418 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M content/browser/geolocation/wifi_data_provider_chromeos.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/geolocation/wifi_data_provider_chromeos.cc View 4 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
robliao
7 years, 3 months ago (2013-09-05 20:09:27 UTC) #1
vadimt
Thanks for sending this for the review, but I'm not familiar with this code :) ...
7 years, 3 months ago (2013-09-05 21:05:09 UTC) #2
robliao
bulach: Please provide owner approval for this CL. Thanks!
7 years, 3 months ago (2013-09-05 21:07:26 UTC) #3
Michael van Ouwerkerk
lgtm but I'm not officially an owner yet so you still need Marcus :-)
7 years, 3 months ago (2013-09-06 10:40:00 UTC) #4
bulach
lgtm, thanks!
7 years, 3 months ago (2013-09-06 15:15:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/23889009/1
7 years, 3 months ago (2013-09-06 15:31:32 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 3 months ago (2013-09-06 18:11:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/23889009/1
7 years, 3 months ago (2013-09-06 18:13:38 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 18:13:58 UTC) #9
Message was sent while issue was closed.
Change committed as 221737

Powered by Google App Engine
This is Rietveld 408576698