Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 23882006: Fix a compilation error with order_profiling=1. (Closed)

Created:
7 years, 3 months ago by Maria
Modified:
7 years, 3 months ago
Reviewers:
Anton, Charlie Reis
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix a compilation error with order_profiling=1. The above file was excluded in https://chromiumcodereview.appspot.com/23030005/, but is necessary for successful compilation when order_profiling flag is enabled. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Maria
7 years, 3 months ago (2013-09-04 18:10:04 UTC) #1
Charlie Reis
Is this the only thing from https://chromiumcodereview.appspot.com/23030005/ that is affected by order_profiling=1? I admit that ...
7 years, 3 months ago (2013-09-04 18:23:41 UTC) #2
Maria
On 2013/09/04 18:23:41, creis wrote: > Is this the only thing from https://chromiumcodereview.appspot.com/23030005/ > that ...
7 years, 3 months ago (2013-09-04 18:30:12 UTC) #3
Charlie Reis
Ok, rubber stamp LGTM. Sorry for the disruption.
7 years, 3 months ago (2013-09-04 18:40:11 UTC) #4
Maria
On 2013/09/04 18:40:11, creis wrote: > Ok, rubber stamp LGTM. Sorry for the disruption. Thanks!
7 years, 3 months ago (2013-09-04 18:46:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mariakhomenko@chromium.org/23882006/1
7 years, 3 months ago (2013-09-04 18:46:27 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 22:16:19 UTC) #7
Message was sent while issue was closed.
Change committed as 221280

Powered by Google App Engine
This is Rietveld 408576698