Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 23882003: Fix Views Combobox and TreeView input minimally. (Closed)

Created:
7 years, 3 months ago by msw
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, Seigo Nonaka, kochi, yukawa, Yusuke Sato, kenjibaheux, Dane Wallinga
Visibility:
Public.

Description

Fix Views Combobox and TreeView input minimally. Fixes r216992's regression (input not sent to Combobox/TreeView). Call views::InputMethod::On[Focus|Blur] for Combobox and TreeView. This correctly forwards input method input to the focused views. (this minimal CL should be mergeable to fix this issue in M-30) I had landed a fix that was more complex: http://crrev.com/219673 That caused regressions and was reverted: http://crrev.com/220121 Both CLs should be superceded by: http://crrev.com/23583013 (but that CL is a complex WIP proof of concept, not mergeable) BUG=276720 TEST=Test Win (desktop, Win8 Metro, and Aura builds), CrOS, and Linux Aura's Omnibox, Find Bar, Bookmark Bubble, and Edit Bookmark Dialog's textfield text entry (and text input handling to select combobox and tree view elements) with EN, JA, and other IMEs, and related IME usage (Win+Space to change IME on Win8, Alt+` to change modes, etc.). Also test with --enable-text-services-framework. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/views/controls/combobox/combobox.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/views/controls/tree/tree_view.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
msw
Hey Scott, please take a look; thanks!
7 years, 3 months ago (2013-09-03 22:41:31 UTC) #1
sky
LGTM
7 years, 3 months ago (2013-09-04 00:05:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/23882003/1
7 years, 3 months ago (2013-09-04 00:10:02 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 17:28:07 UTC) #4
Message was sent while issue was closed.
Change committed as 221221

Powered by Google App Engine
This is Rietveld 408576698