Issue 23881004: Delete useless CompileStoreGlobal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23881004: Delete useless CompileStoreGlobal (Closed)

Created:
7 years, 3 months ago by weiliang.lin2

Modified:
7 years, 3 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

Delete useless CompileStoreGlobal StoreGlobal stubs are generated by Hydrogen now BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16653

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -177 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View		1 chunk	+0 lines, -41 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		1 chunk	+0 lines, -42 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View		1 chunk	+0 lines, -40 lines	0 comments	Download
M	src/stub-cache.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		1 chunk	+0 lines, -42 lines	0 comments	Download

Total messages: 5 (0 generated)

Toon Verwaest

CompileStoreGlobal is still mentioned in code-stubs-<platform>.cc. If you remove that, LGTM. Thanks for cleaning up ...

7 years, 3 months ago (2013-09-11 11:49:34 UTC) #3

weiliang.lin2

On 2013/09/11 11:49:34, Toon Verwaest wrote: > CompileStoreGlobal is still mentioned in code-stubs-<platform>.cc. If you ...

7 years, 3 months ago (2013-09-11 12:44:32 UTC) #4

Toon Verwaest

7 years, 3 months ago (2013-09-11 13:35:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r16653 (presubmit successful).