Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: base/threading/platform_thread_posix.cc

Issue 23875025: [POSIX] CHECK that pthread_join succeeds in PlatformThread::Join. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/threading/platform_thread.h" 5 #include "base/threading/platform_thread.h"
6 6
7 #include <errno.h> 7 #include <errno.h>
8 #include <sched.h> 8 #include <sched.h>
9 9
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 delegate, &unused, kThreadPriority_Normal); 218 delegate, &unused, kThreadPriority_Normal);
219 return result; 219 return result;
220 } 220 }
221 221
222 // static 222 // static
223 void PlatformThread::Join(PlatformThreadHandle thread_handle) { 223 void PlatformThread::Join(PlatformThreadHandle thread_handle) {
224 // Joining another thread may block the current thread for a long time, since 224 // Joining another thread may block the current thread for a long time, since
225 // the thread referred to by |thread_handle| may still be running long-lived / 225 // the thread referred to by |thread_handle| may still be running long-lived /
226 // blocking tasks. 226 // blocking tasks.
227 base::ThreadRestrictions::AssertIOAllowed(); 227 base::ThreadRestrictions::AssertIOAllowed();
228 pthread_join(thread_handle.handle_, NULL); 228 CHECK_EQ(0, pthread_join(thread_handle.handle_, NULL));
229 } 229 }
230 230
231 } // namespace base 231 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698