Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 23875022: [Aura] Always use IMM32 on desktop Chrome (non-Ash mode) (Closed)

Created:
7 years, 3 months ago by yukawa
Modified:
7 years, 3 months ago
Reviewers:
msw, cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, erikwright+watch_chromium.org, ananta, Seigo Nonaka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Aura] Always use IMM32 on desktop Chrome (non-Ash mode) This CL partially reverts r194205, which aimed to support IME for Ash. With this partial rollback, we can assume that all the instances of Aura-Win Chrome running in desktop use IMM32 regardless of the OS version. Given that Ash IME support is not functional yet, there is no strong reason to force TSF only on Win8+. Actually our IMM32 implemenation is more robust than that of TSF. This way should lower the risk of successful launch of Aura for Windows in M31. BUG=164964 TEST=manually confirmed that we can use IME with Win8 Aura build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M base/win/metro.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
yukawa
Could you take a look?
7 years, 3 months ago (2013-09-13 15:51:13 UTC) #1
cpu_(ooo_6.6-7.5)
Hopefully we can enable TSF in the future. lgtm
7 years, 3 months ago (2013-09-13 20:57:09 UTC) #2
yukawa
Thx! I hope we can reenable TSF for Ash as soon as possible. Mike, could ...
7 years, 3 months ago (2013-09-14 07:11:51 UTC) #3
cpu_(ooo_6.6-7.5)
if we are going to land this please do it so in the next 24 ...
7 years, 3 months ago (2013-09-17 02:31:06 UTC) #4
msw
LGTM; but the r194204 cited in the CL description looks unrelated...
7 years, 3 months ago (2013-09-17 02:34:05 UTC) #5
yukawa
On 2013/09/17 02:34:05, msw wrote: > LGTM; but the r194204 cited in the CL description ...
7 years, 3 months ago (2013-09-17 02:37:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/23875022/1
7 years, 3 months ago (2013-09-17 02:38:14 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=79654
7 years, 3 months ago (2013-09-17 09:23:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/23875022/1
7 years, 3 months ago (2013-09-17 09:31:07 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 12:04:22 UTC) #10
Message was sent while issue was closed.
Change committed as 223589

Powered by Google App Engine
This is Rietveld 408576698