Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 23875014: Simplify InputMethodBridgeUnitTest (Closed)

Created:
7 years, 3 months ago by Yohei Yukawa
Modified:
7 years, 3 months ago
CC:
chromium-reviews, nona+watch_chromium.org, James Su, tfarina, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Simplify InputMethodBridgeUnitTest This is a refactoring CL as a preparation to fix focus handling on Win-Aura environment. This CL does not change any behavior of production binaries. Currently InputMethodBridgeUnitTest internally defines a custom dummy class of ui::InputMethod. However this is not necessary because we already have ui::FakeInputMethod. This CL replaces the custom dummy class with ui::FakeInputMethod by using DummyInputMethodDelegate. We can reuse ui::DummyInputMethodDelegate later in other unit tests. BUG=287620 TEST=unit test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222255

Patch Set 1 #

Patch Set 2 : Remove unnecessary blank line at the end of file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -35 lines) Patch
A ui/base/ime/dummy_input_method_delegate.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
A ui/base/ime/dummy_input_method_delegate.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download
M ui/base/ime/ime.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/ime/input_method_bridge_unittest.cc View 2 chunks +5 lines, -35 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Yohei Yukawa
7 years, 3 months ago (2013-09-09 17:03:23 UTC) #1
Seigo Nonaka
lgtm
7 years, 3 months ago (2013-09-10 02:25:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/23875014/1
7 years, 3 months ago (2013-09-10 02:29:17 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 02:52:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/23875014/23001
7 years, 3 months ago (2013-09-10 03:35:27 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 03:58:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/23875014/23001
7 years, 3 months ago (2013-09-10 09:26:44 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=167385
7 years, 3 months ago (2013-09-10 11:25:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/23875014/23001
7 years, 3 months ago (2013-09-10 11:47:11 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 12:33:59 UTC) #10
Message was sent while issue was closed.
Change committed as 222255

Powered by Google App Engine
This is Rietveld 408576698