Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: extensions/browser/file_highlighter_unittest.cc

Issue 23875013: Handle invalid input for SourceHighlighter, Don't Allow Relative Paths in ErrorHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove comment + address security risk in ErrorHandler Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/file_highlighter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/file_highlighter_unittest.cc
diff --git a/extensions/browser/file_highlighter_unittest.cc b/extensions/browser/file_highlighter_unittest.cc
index 6352be4b0dcfae86cec49f325d95861dab939edf..a449bf903c2a20e6b80a4385ea0b43fd78f986d7 100644
--- a/extensions/browser/file_highlighter_unittest.cc
+++ b/extensions/browser/file_highlighter_unittest.cc
@@ -95,4 +95,26 @@ TEST(ManifestHighlighterUnitTest, ManifestHighlighterUnitTest) {
EXPECT_EQ(kInternationalFeature, international_feature.GetFeature());
}
+TEST(SouceHighlighterUnitTest, SourceHighlighterUnitTest) {
+ const char kBasicSourceFile[] = "line one\nline two\nline three";
+
+ SourceHighlighter basic1(kBasicSourceFile, 1u);
+ EXPECT_EQ("line one", basic1.GetFeature());
+ SourceHighlighter basic2(kBasicSourceFile, 2u);
+ EXPECT_EQ("line two", basic2.GetFeature());
+ SourceHighlighter basic3(kBasicSourceFile, 3u);
+ EXPECT_EQ("line three", basic3.GetFeature());
+
+ const char kNoNewlineSourceFile[] = "thisisonelonglinewithnobreaksinit";
+
+ SourceHighlighter full_line(kNoNewlineSourceFile, 1u);
+ EXPECT_EQ(kNoNewlineSourceFile, full_line.GetFeature());
+
+ SourceHighlighter line_zero(kNoNewlineSourceFile, 0u);
+ EXPECT_EQ(EmptyString(), line_zero.GetFeature());
+
+ SourceHighlighter out_of_bounds(kNoNewlineSourceFile, 2u);
+ EXPECT_EQ(EmptyString(), out_of_bounds.GetFeature());
+}
+
} // namespace extensions
« no previous file with comments | « extensions/browser/file_highlighter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698