Issue 23875013: Handle invalid input for SourceHighlighter, Don't Allow Relative Paths in ErrorHandler

Issue 23875013: Handle invalid input for SourceHighlighter, Don't Allow Relative Paths in ErrorHandler (Closed)

Created:
7 years, 3 months ago by Devlin

Modified:
7 years, 3 months ago

Reviewers:
Finnur

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Handle invalid input, add more tests for SourceHighlighter In response to Finnur's @ 23624002 BUG=21734 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222330

Patch Set 2 : Remove comment + address security risk in ErrorHandler #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -5 lines)			Patch
M	chrome/browser/ui/webui/extensions/extension_error_handler.cc	View	1	3 chunks	+10 lines, -3 lines	0 comments	Download
M	extensions/browser/file_highlighter.cc	View	1	1 chunk	+13 lines, -2 lines	0 comments	Download
M	extensions/browser/file_highlighter_unittest.cc	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Finnur

https://codereview.chromium.org/23875013/diff/1/extensions/browser/file_highlighter.cc File extensions/browser/file_highlighter.cc (right): https://codereview.chromium.org/23875013/diff/1/extensions/browser/file_highlighter.cc#newcode215 extensions/browser/file_highlighter.cc:215: // to be at the first character of the ...

7 years, 3 months ago (2013-09-09 18:19:30 UTC) #2

Devlin

Also added check in ExtensionErrorHandler. https://codereview.chromium.org/23875013/diff/1/extensions/browser/file_highlighter.cc File extensions/browser/file_highlighter.cc (right): https://codereview.chromium.org/23875013/diff/1/extensions/browser/file_highlighter.cc#newcode215 extensions/browser/file_highlighter.cc:215: // to be at ...

7 years, 3 months ago (2013-09-09 18:26:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/23875013/6001

7 years, 3 months ago (2013-09-10 14:56:29 UTC) #5

Message was sent while issue was closed.

Change committed as 222330

Expand Messages | Collapse Messages