Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 23875004: Another attempt to fix a Chrome crash. (Closed)

Created:
7 years, 3 months ago by honghaiz
Modified:
7 years, 3 months ago
CC:
Matt Welsh, chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Another attempt to fix a Chrome crash. From the bug report and the other relevant bug 236392 reported by ASan, The problem arises when ReadData() had some errors or completed, and then freed the NetworkStats, but later the callback of the Write() is started on the freed object. This most likely happened when the initial ReadData() had some errors. So I did two modifications. 1. For the first time when ReadData is called, I checked the return value. Only if it is ERR_IO_PENDING, it continues to Send requests. 2. The Write() callback is on a WeakPtr. If the NetworkStats object is freed, the callback will be a no-op. BUG=273917 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M chrome/browser/net/network_stats.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/net/network_stats.cc View 5 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
honghaiz
7 years, 3 months ago (2013-09-03 18:19:48 UTC) #1
honghaiz
On 2013/09/03 18:19:48, honghaiz wrote: Ping for code review.
7 years, 3 months ago (2013-09-04 18:46:20 UTC) #2
honghaiz
I hope to get the fix into the canary before the weekend. Can you provide ...
7 years, 3 months ago (2013-09-05 17:23:35 UTC) #3
jar (doing other things)
lgtm
7 years, 3 months ago (2013-09-05 21:17:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/honghaiz@chromium.org/23875004/1
7 years, 3 months ago (2013-09-05 21:35:44 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 08:21:40 UTC) #6
Message was sent while issue was closed.
Change committed as 221644

Powered by Google App Engine
This is Rietveld 408576698