Add a function to send scripts from a browsertest to an extension's background page.

Add a function to send scripts from a browsertest to an extension's background page.

This lets browsertests and apitests use more obvious code in some
cases, especially when they need to alternate between the background
page and the test running code.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221216

[Jeffrey Yasskin, 2013-09-03 23:01:39]

I'm also using this at
https://codereview.chromium.org/19045002/diff/5001/chrome/browser/extensions/...
to run extension code after manipulating the set of open tabs.

[not at google - send to devlin, 2013-09-03 23:13:38]

despite my comment, reading this I think this utility should go on
extension_browsertest.cc. There are many places where we using
ExecuteScriptInBackgroundPage will be more convenient than any other way of
doing things, and the only way test writers will know about this method (and
accept it as being idiomatic) is if it's on ExtensionBrowsertest.

It may make sense to just add it to ExtensionBrowsertest and have that call the
util itself.

https://codereview.chromium.org/23874006/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_browsertest_util.h (right):

https://codereview.chromium.org/23874006/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_browsertest_util.h:6: #define
CHROME_BROWSER_EXTENSIONS_EXTENSION_BROWSERTEST_UTIL_H_
just browsertest_util?

https://codereview.chromium.org/23874006/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_browsertest_util.h:13: 
can we put this file in a browsertest_util namespace?

https://codereview.chromium.org/23874006/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_browsertest_util.h:14: // Waits until
|script| calls "window.domAutomationController.send('string')"
what is 'string'?

[not at google - send to devlin, 2013-09-03 23:14:39]

lgtm either way

[Jeffrey Yasskin, 2013-09-03 23:33:13]

On 2013/09/03 23:13:38, kalman wrote:
> despite my comment, reading this I think this utility should go on
> extension_browsertest.cc. There are many places where we using
> ExecuteScriptInBackgroundPage will be more convenient than any other way of
> doing things, and the only way test writers will know about this method (and
> accept it as being idiomatic) is if it's on ExtensionBrowsertest.
> 
> It may make sense to just add it to ExtensionBrowsertest and have that call
the
> util itself.

I picked the option for a thin wrapper. How do you like the comment there, and
the other changes?

https://codereview.chromium.org/23874006/diff/1/chrome/browser/extensions/ext...
File chrome/browser/extensions/extension_browsertest_util.h (right):

https://codereview.chromium.org/23874006/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_browsertest_util.h:6: #define
CHROME_BROWSER_EXTENSIONS_EXTENSION_BROWSERTEST_UTIL_H_
On 2013/09/03 23:13:38, kalman wrote:
> just browsertest_util?

Sure, done.

https://codereview.chromium.org/23874006/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_browsertest_util.h:13: 
On 2013/09/03 23:13:38, kalman wrote:
> can we put this file in a browsertest_util namespace?

After some discussion about a 'testing' namespace (downside: using gtest and
gmock facilities inside the extensions namespace would now require writing
"::testing"), we agree to use browsertest_util, to help people reading code
figure out what file to look in to find these functions.

https://codereview.chromium.org/23874006/diff/1/chrome/browser/extensions/ext...
chrome/browser/extensions/extension_browsertest_util.h:14: // Waits until
|script| calls "window.domAutomationController.send('string')"
On 2013/09/03 23:13:38, kalman wrote:
> what is 'string'?

How's the new comment?

[not at google - send to devlin, 2013-09-04 02:12:50]

still lgtm

[not at google - send to devlin, 2013-09-04 02:15:16]

lgtm

https://chromiumcodereview.appspot.com/23874006/diff/14001/chrome/browser/ext...
File chrome/browser/extensions/browsertest_util.h (right):

https://chromiumcodereview.appspot.com/23874006/diff/14001/chrome/browser/ext...
chrome/browser/extensions/browsertest_util.h:18: // have a background page, or
if executing the script fails.
what happens if the test doesn't return a string? (I'm pretty sure it should
fail the test)

[Jeffrey Yasskin, 2013-09-04 02:48:44]

https://chromiumcodereview.appspot.com/23874006/diff/14001/chrome/browser/ext...
File chrome/browser/extensions/browsertest_util.h (right):

https://chromiumcodereview.appspot.com/23874006/diff/14001/chrome/browser/ext...
chrome/browser/extensions/browsertest_util.h:18: // have a background page, or
if executing the script fails.
On 2013/09/04 02:15:16, kalman wrote:
> what happens if the test doesn't return a string? (I'm pretty sure it should
> fail the test)

Yep, and now I've tested that.

[commit-bot: I haz the power, 2013-09-04 02:48:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/23874006/30001

[commit-bot: I haz the power, 2013-09-04 17:18:35]

Change committed as 221216