Fix teardown in tests which use UploadFileElementReader.

Fix teardown in tests which use UploadFileElementReader.

This fixes memory leaks in UploadFileElementReader and UploadDataStream tests.

BUG=290897
R=rsleevi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223344

[earthdok, 2013-09-13 16:11:02]

please take a look

[Ryan Sleevi, 2013-09-13 18:47:10]

https://codereview.chromium.org/23872030/diff/1/net/base/upload_data_stream_u...
File net/base/upload_data_stream_unittest.cc (right):

https://codereview.chromium.org/23872030/diff/1/net/base/upload_data_stream_u...
net/base/upload_data_stream_unittest.cc:135: }
You should be able to update these according to
https://code.google.com/p/googletest/wiki/V1_6_FAQ#Should_I_use_the_construct...

https://codereview.chromium.org/23872030/diff/1/net/base/upload_file_element_...
File net/base/upload_file_element_reader_unittest.cc (right):

https://codereview.chromium.org/23872030/diff/1/net/base/upload_file_element_...
net/base/upload_file_element_reader_unittest.cc:54: }
Ditto here - it should be possible to update these to
https://code.google.com/p/googletest/wiki/V1_6_FAQ#Should_I_use_the_construct...

[earthdok, 2013-09-13 19:18:13]

On 2013/09/13 18:47:10, Ryan Sleevi wrote:
>
https://codereview.chromium.org/23872030/diff/1/net/base/upload_data_stream_u...
> File net/base/upload_data_stream_unittest.cc (right):
> 
>
https://codereview.chromium.org/23872030/diff/1/net/base/upload_data_stream_u...
> net/base/upload_data_stream_unittest.cc:135: }
> You should be able to update these according to
>
https://code.google.com/p/googletest/wiki/V1_6_FAQ#Should_I_use_the_construct...
> 
>
https://codereview.chromium.org/23872030/diff/1/net/base/upload_file_element_...
> File net/base/upload_file_element_reader_unittest.cc (right):
> 
>
https://codereview.chromium.org/23872030/diff/1/net/base/upload_file_element_...
> net/base/upload_file_element_reader_unittest.cc:54: }
> Ditto here - it should be possible to update these to
>
https://code.google.com/p/googletest/wiki/V1_6_FAQ#Should_I_use_the_construct...

Done. This kind of contradicts
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Doing_...
but I don't have a strong opinion here.

[Ryan Sleevi, 2013-09-13 21:57:27]

lgtm

https://codereview.chromium.org/23872030/diff/6001/net/base/upload_data_strea...
File net/base/upload_data_stream_unittest.cc (right):

https://codereview.chromium.org/23872030/diff/6001/net/base/upload_data_strea...
net/base/upload_data_stream_unittest.cc:130: ~UploadDataStreamTest() {
style nit: virtual

https://codereview.chromium.org/23872030/diff/6001/net/base/upload_file_eleme...
File net/base/upload_file_element_reader_unittest.cc (right):

https://codereview.chromium.org/23872030/diff/6001/net/base/upload_file_eleme...
net/base/upload_file_element_reader_unittest.cc:47:
~UploadFileElementReaderTest() {
style nit: virtual
style nit: line break after }

[commit-bot: I haz the power, 2013-09-16 10:47:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/earthdok@chromium.org/23872030/11001

[commit-bot: I haz the power, 2013-09-16 11:06:51]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[earthdok, 2013-09-16 11:23:34]

On 2013/09/16 11:06:51, I haz the power (commit-bot) wrote:
> Sorry for I got bad news for ya.
> Compile failed with a clobber build on linux_aura.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
> Your code is likely broken or HEAD is junk. Please ensure your
> code is not broken then alert the build sheriffs.
> Look at the try server FAQ for more details.

Ah - no fatal assertions allowed in constructors. I'll change the constructors
back to SetUp(), but the teardown code can still be in destructors - unless you
have stylistic objections to that.

[commit-bot: I haz the power, 2013-09-16 13:03:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/earthdok@chromium.org/23872030/30001

[commit-bot: I haz the power, 2013-09-16 15:27:08]

Change committed as 223344