Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 23868021: Prepare ExternalPolicyDataUpdater and ResourceCache for blocking pool (Closed)

Created:
7 years, 3 months ago by bartfab (slow)
Modified:
7 years, 3 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Prepare ExternalPolicyDataUpdater and ResourceCache for blocking pool This CL allows the ExternalPolicyDataUpdater and ResourceCache classes to be used in the blocking pool. It is a prerequisite for CL 22562003 which will add code to downloading and caching of external policy data that runs in the blocking pool and uses these classes. BUG=256635 TEST=Updated unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223340

Patch Set 1 : Re-uploading due to rietveld flake. #

Messages

Total messages: 6 (0 generated)
bartfab (slow)
Hi Joao, Could you please review?
7 years, 3 months ago (2013-09-12 16:55:41 UTC) #1
bartfab (slow)
Hi Mattias, Joao is very busy right now. Would you have the cycles to review?
7 years, 3 months ago (2013-09-12 16:56:33 UTC) #2
bartfab (slow)
Hi Daniel, Since you offered to review - feel free to take a look :).
7 years, 3 months ago (2013-09-16 11:29:31 UTC) #3
Mattias Nissler (ping if slow)
LGTM
7 years, 3 months ago (2013-09-16 11:42:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/23868021/10001
7 years, 3 months ago (2013-09-16 12:16:31 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-16 14:38:52 UTC) #6
Message was sent while issue was closed.
Change committed as 223340

Powered by Google App Engine
This is Rietveld 408576698