Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 23866010: Add icons for feedback. (Closed)

Created:
7 years, 3 months ago by rkc
Modified:
7 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Add icons for feedback. The feedback manifest doesn't contain the correct icons to show on the app shelf. Add them. R=xiyuan@chromium.org BUG=291381 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/resources/feedback/images/icon32.png View Binary file 0 comments Download
A chrome/browser/resources/feedback/images/icon64.png View Binary file 0 comments Download
M chrome/browser/resources/feedback/manifest.json View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rkc
7 years, 3 months ago (2013-09-16 21:32:40 UTC) #1
xiyuan
lgtm
7 years, 3 months ago (2013-09-16 21:37:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/23866010/1
7 years, 3 months ago (2013-09-16 21:42:41 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 01:03:31 UTC) #4
Message was sent while issue was closed.
Change committed as 223495

Powered by Google App Engine
This is Rietveld 408576698