Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Issue 23866007: Fix painting order for floats with shape-outside (Closed)

Created:
7 years, 3 months ago by Bem Jones-Bey (adobe)
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Fix painting order for floats with shape-outside When removing the old positioning behavior, the code that makes a float with shape-outside gain a layer was left behind. This patch removes that, so now floats with shape-outside are painted just like floats without shape-outside. Also remove the isFloatingWithShapeOutside helper method because its use is now somewhat redundant, and the check it does is now only needed in one place. BUG=286448 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -38 lines) Patch
M LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html View 2 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html View 2 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html View 2 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html View 2 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html View 2 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html View 2 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html View 1 chunk +9 lines, -8 lines 0 comments Download
M LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html View 2 chunks +25 lines, -25 lines 0 comments Download
M LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-stacked-000.html View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-not-a-layer.html View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-not-a-layer-expected.html View 1 chunk +24 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/shapes/ShapeOutsideInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Bem Jones-Bey (adobe)
7 years, 3 months ago (2013-09-06 21:57:54 UTC) #1
eseidel
lgtm
7 years, 3 months ago (2013-09-06 22:04:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bjonesbe@adobe.com/23866007/1
7 years, 3 months ago (2013-09-06 22:04:34 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 23:41:50 UTC) #4
Message was sent while issue was closed.
Change committed as 157396

Powered by Google App Engine
This is Rietveld 408576698