Delay delay launch of local discovery notification service.

Delay delay launch of local discovery notification service.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221971

[Noam Samuel, 2013-09-08 16:00:58]

On 2013/09/08 07:42:21, Vitaly Buka wrote:

Is this in part to avoid test failures? As for the test failures, is there a
more robust/less flaky solution we can take now/later? Regardless, this is a
good idea because it ensures there won't be multiple chrome instances querying
/info on a printer in too short a time.

lgtm

[Noam Samuel, 2013-09-08 16:03:50]

On 2013/09/08 16:00:58, Noam Samuel wrote:
> On 2013/09/08 07:42:21, Vitaly Buka wrote:
> 
> Is this in part to avoid test failures? As for the test failures, is there a
> more robust/less flaky solution we can take now/later? Regardless, this is a
> good idea because it ensures there won't be multiple chrome instances querying
> /info on a printer in too short a time.
> 
> lgtm

For testing purposes, maybe we can create a separate flag to disable
notifications and put it here?
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/tes...

[Vitaly Buka (NO REVIEWS), 2013-09-09 00:42:36]

On 2013/09/08 16:03:50, Noam Samuel wrote:
> On 2013/09/08 16:00:58, Noam Samuel wrote:
> > On 2013/09/08 07:42:21, Vitaly Buka wrote:
> > 
> > Is this in part to avoid test failures? As for the test failures, is there a
> > more robust/less flaky solution we can take now/later? Regardless, this is a
> > good idea because it ensures there won't be multiple chrome instances
querying
> > /info on a printer in too short a time.
> > 
> > lgtm
> 
> For testing purposes, maybe we can create a separate flag to disable
> notifications and put it here?
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/tes...

It's not for testing presuppose. Goal to avoid unnecessary work on browser
startup.

[Vitaly Buka (NO REVIEWS), 2013-09-09 00:44:34]

On 2013/09/08 16:00:58, Noam Samuel wrote:
> On 2013/09/08 07:42:21, Vitaly Buka wrote:
> 
> Is this in part to avoid test failures? As for the test failures, is there a
> more robust/less flaky solution we can take now/later? Regardless, this is a
> good idea because it ensures there won't be multiple chrome instances querying
> /info on a printer in too short a time.
> 
> lgtm

btw. tests were fixed by
PrivetNotificationServiceFactory::ServiceIsNULLWhileTesting

[commit-bot: I haz the power, 2013-09-09 00:44:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23863004/1

[commit-bot: I haz the power, 2013-09-09 01:59:04]

Change committed as 221971