Issue 23861007: DevTools: Fix console output for native functions like Math.random

Issue 23861007: DevTools: Fix console output for native functions like Math.random (Closed)

Created:
7 years, 3 months ago by vsevik

Modified:
7 years, 3 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Fix console output for native functions like Math.random Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157372

Patch Set 1 #

Patch Set 2 : Updated test expectations #

Total comments: 2

Patch Set 3 : Comments addressed #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -11 lines)			Patch
A +	LayoutTests/inspector/console/console-native-function.html	View	1 2	1 chunk	+4 lines, -9 lines	0 comments	Download
A	LayoutTests/inspector/console/console-native-function-expected.txt	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/ConsoleView.js	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pfeldman

https://codereview.chromium.org/23861007/diff/4001/LayoutTests/inspector/console/console-format-expected.txt File LayoutTests/inspector/console/console-format-expected.txt (right): https://codereview.chromium.org/23861007/diff/4001/LayoutTests/inspector/console/console-format-expected.txt#newcode19 LayoutTests/inspector/console/console-format-expected.txt:19: CONSOLE MESSAGE: line 54: function random() { [native code] ...

7 years, 3 months ago (2013-09-05 11:42:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/23861007/9001

7 years, 3 months ago (2013-09-06 14:49:06 UTC) #5

Message was sent while issue was closed.

Change committed as 157372

Expand Messages | Collapse Messages