Issue 23861005: Fix NULL deref in HistoryBackend::ExpireHistoryBetween.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23861005: Fix NULL deref in HistoryBackend::ExpireHistoryBetween. (Closed)

Created:
7 years, 3 months ago by grt (UTC plus 2)

Modified:
7 years, 3 months ago

Reviewers:
brettw

CC:
chromium-reviews, browser-components-watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix NULL deref in HistoryBackend::ExpireHistoryBetween. We're seeing crashes in history::VisitDatabase::GetStartDate coming from HistoryBackend::ExpireHistoryBetween where db_ is NULL. This change mitigates this by two avenues: first_recorded_time_ is cleared when the DB is closed (so that no other code that checks it blows up), and GetStartDate is no longer called by ExpireHistoryBetween when db_ is NULL. Evidence suggests that this bug is responsible for browser crashes at shutdown that result in a corrupt profile dialog on the next launch. BUG=275916, 273832, 165282, 107613, 36588 R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221802