Issue 23857008: Re-land: "RenderTextWin: Break runs between any two characters that are not in the same code block"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23857008: Re-land: "RenderTextWin: Break runs between any two characters that are not in the same code block" (Closed)

Created:
7 years, 3 months ago by ckocagil

Modified:
7 years, 3 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Re-land: "RenderTextWin: Break runs between any two characters that are not in the same code block" Original CL: https://codereview.chromium.org/23522018/ Last CL had a mid-air collision with r221762. It is now merged. BUG=278913 TBR=asvitkine@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221850

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -7 lines)			Patch
M	ui/gfx/render_text_unittest.cc	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	ui/gfx/render_text_win.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/gfx/render_text_win.cc	View	5 chunks	+33 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

ckocagil

Same as last CL, only with s/ui::Range/Range/ in render_text_unittest.cc. Submitting TBR.

7 years, 3 months ago (2013-09-07 01:20:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/23857008/1

7 years, 3 months ago (2013-09-07 01:22:43 UTC) #2

Message was sent while issue was closed.

lgtm